textpattern / textpacks

Textpattern CMS language files.
https://textpattern.com
GNU General Public License v2.0
23 stars 22 forks source link

Missing string: skin_name_invalid #287

Closed Bloke closed 4 years ago

Bloke commented 4 years ago

Required in [skin] area for times when you (for example) edit a current theme, blank out the name and hit 'Duplicate'.

Not vital for 4.8.0. Can defer to 4.8.1. In fact, there might be a better way to handle this altogether so we may not even need this string, but let's leave it here as a reminder to check this out post-release.

petecooper commented 4 years ago

Bumping this since we're approaching 4.8.2.

Bloke commented 4 years ago

Good bump, thanks. We need to include this.

philwareham commented 4 years ago

Can you provide me some text for this, please?

Bloke commented 4 years ago

I think this should do it:

Theme name <strong>{name}</strong> invalid.

(although I've only managed to trigger it when $name is empty. But to be on the safe side, let's keep the{name} in there, as it'll still read okay if it's missing. Thanks!

philwareham commented 4 years ago

Done, thanks. Closing.