Missing 4.9 prefs strings

[bloatware]

• [x] trailing_slash (Site) – added via https://github.com/textpattern/textpacks/commit/ef8af3829acc828a0ae703becc3fab9e05b79d2a hat tip @rwetzlmayr
• [x] file_download_header (Advanced Options)

[petecooper]

re: trailing_slash – we have site_trailing_slash in textpacks, which is largely translated across the board:

https://github.com/textpattern/textpacks/blob/606e9ac46d334ec0e69f56ef6e82fa44d4c642cd/lang/en-us.ini#L549C6-L549C20

Considerations:

• change the code in core (new string for 4.9 so not a huge deal if we do it now)
• rename the string in textpacks (manual work for Phil)

@Bloke @bloatware - any preference?

[bloatware]

It's a diag error message, not sure it fits here. The trailing slash pref in question decides whether all/none/lists only links should have a trailing slash.

[philwareham]

@petecooper @bloatware @Bloke please either add any 4.9 string requests here or (even better) add them into en.ini and I can sync into Crowdin. Cheers!

[Bloke]

If someone can run the string checker in the toobelt repo, that should hopefully highlight any we've missed. Bearing in mind it's not foolproof.

Edit: wait, it's not there. Hmmm. I swear we had a tool to do that somewhere which romps through the core files looking for gTxt() and pulling the strings out comparing them to the ones in en.ini.

Edit 2: no wait, here it is in the Textpack repo:

https://github.com/textpattern/textpacks/blob/main/tools/check-textpack.php

[petecooper]

I'll take dibs on the checker - likely this evening as I've got a full diary until then. Watch this space.

Edit: I'm getting errors thrown on PHP 8.3 (macOS Homebrew) so I'll hook this into the demo server so we can automate it.

[petecooper]

OK, now automated as part of the dev build (three-hourly):

https://dev-demo.textpattern.co/dev/missing.txt

Needs some tweaks, I think - there seems to be a lot in there.

[Bloke]

Oooh nice one.

Bear in mind that many of these strings might be from deprecated functions (e.g. accountactivation*) so we don't need to bother about them. Not sure how to exclude those. Ideas welcome.

[philwareham]

Hi, I'm back from holiday now. What Strings do I need to add? So far I can tell only one?...

file_download_header

Which I will add now. But what group does it go in (I've put in [prefs] for now?

[bloatware]

file_download_header should go to Advanced Prefs, but I don't remember what the corresponding ini section is.

[Bloke]

file_download_header should go to Advanced Prefs, but I don't remember what the corresponding ini section is.

We don't distinguish, as far as I recall. [prefs] should be fine.