search

texworld / betterbib

:green_book: Command-line tools for bibliographies.
816 stars 42 forks source link

Fix/preamble #199

Closed JensHeinrich closed 3 years ago

JensHeinrich commented 3 years ago

Solves #198

JensHeinrich commented 3 years ago

The broken checks are in code I did't touch and I really don't get it ATM

nschloe commented 3 years ago

Do we need the option to drop the preamble?

JensHeinrich commented 3 years ago

Same reasoning as the last time: It's the current behaviour

nschloe commented 3 years ago

If I understand corrent, if no @preamble is present, the behavior is unchanged. If this is the case, we don't need a flag. Or is there a good reason to disable it?

JensHeinrich commented 3 years ago

Currently if there are @preamble entries they are removed when running betterbib format (that's the main reason I created the PR...)

nschloe commented 3 years ago

Alright, let's remove --keep-preamble and always keep it.

JensHeinrich commented 3 years ago

done

nschloe commented 3 years ago

Thanks!