search

texx00 / sandypi

The ultimate controller for sand tables
Other
28 stars 4 forks source link

Error on index for path drawing widget[BUG] #40

Closed vincentbraillard closed 3 years ago

vincentbraillard commented 3 years ago

Describe the bug When I add new drawing, the widget are well. but when I delete one and just after I upload a new one, the visualisation doesn't fit with the file. Like a index shift!

To Reproduce Steps to reproduce the behavior: see upside

Expected behavior be the right drawing shown

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Could you use a thinner pen to draw the path because with complex path, the widget is full white

texx00 commented 3 years ago

I was not working on this, but I found out the origin of the problem. The problem is that when the last uploaded drawing is deleted, the same id is used again in the next uploaded drawing. This means that the frontend will use the old cached image instead of using the fresh one. I'm trying to make it work with the autoincrement of the drawing id but sqlite is not working as expecting (the autoincrement option for the primary key should fix the problem but I do not know why it is not working as expected). I will put in place a workaround (not the most elegant solution but the right way is not working, don't understand why). Should be fixed from commit ce34405. Will be available to test with the queue page update

vincentbraillard commented 3 years ago

Hello

Unfortunately it didn't work. It's maybe worse. I had to upload 4 times to have the right index (draw) see bellow. It is the last firmware ce34405 https://github.com/texx00/sandypi/commit/ce34405a7937575bc92e2e89f50f7cd0a06350d1

Le mar. 6 avr. 2021 à 20:21, Luca Tessaro @.***> a écrit :

I was not working on this, but I found out the origin of the problem. The problem is that when the last uploaded drawing is deleted, the same id is used again in the next uploaded drawing. This means that the frontend will use the old cached image instead of using the fresh one. I'm trying to make it work with the autoincrement of the drawing id but sqlite is not working as expecting (the autoincrement option for the primary key should fix the problem but I do not know why it is not working as expected). I will put in place a workaround (not the most elegant solution but the right way is not working, don't understand why. Should be fixed from commit ce34405 https://github.com/texx00/sandypi/commit/ce34405a7937575bc92e2e89f50f7cd0a06350d1. Will be available to test with the queue page update

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/texx00/sandypi/issues/40#issuecomment-814339799, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANLNNJYZ4NLWZO6D7IOMHMLTHNGMJANCNFSM4Z4WVB7Q .

texx00 commented 3 years ago

I cannot see any picture, sorry. To finally fix the problem you must clear the browser cache. If you do that it should work. I got an idea that may fix also this thing about the browser cache not cleared between updates. I will try to put it in soon.

vincentbraillard commented 3 years ago

Sorry. Here the picture...

Le mer. 7 avr. 2021 à 11:52, Luca Tessaro @.***> a écrit :

I cannot see any picture, sorry. To finally fix the problem you must clear the browser cache. If you do that it should work. I got an idea that may fix also this thing about the browser cache not cleared between updates. I will try to put it in soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/texx00/sandypi/issues/40#issuecomment-814777996, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANLNNJZHA466JKPFMHIBZ6TTHQTM3ANCNFSM4Z4WVB7Q .

vincentbraillard commented 3 years ago

Hello

Clearing the cache solve the issue... ;-)

Le mer. 7 avr. 2021 à 11:52, Luca Tessaro @.***> a écrit :

I cannot see any picture, sorry. To finally fix the problem you must clear the browser cache. If you do that it should work. I got an idea that may fix also this thing about the browser cache not cleared between updates. I will try to put it in soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/texx00/sandypi/issues/40#issuecomment-814777996, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANLNNJZHA466JKPFMHIBZ6TTHQTM3ANCNFSM4Z4WVB7Q .

--

Vincent Braillard Impasse de Sappé 32 1645 Pont-en-Ogoz - CH TEL: +41 78 714 16 26

texx00 commented 3 years ago

Should be fixed