search

texx00 / sandypi

The ultimate controller for sand tables
Other
27 stars 5 forks source link

Enhancement/feeder refactoring #68

Open texx00 opened 2 years ago

texx00 commented 2 years ago

Refactoring the feeder and other classes to make the code tidier and to have a better structure for future developments like time estimators

texx00 commented 2 years ago

Will close #53

texx00 commented 2 years ago

The on_device_ready is causing troubles. I don't understand where but there is a deadlock probably... Need to check it better

This is also why the "pages" test was failing

texx00 commented 2 years ago

For the automatic tests failing: looks like the "start next" action is causing the problem. When the action is started with an empty queue it uses the "start random drawing" which for some reason is going into a recursion with the start_next function of the queue manager. I'm not able to replicate the error in my environment, it is like this only in the github setup as far as I can understand. For the moment fixed by exiting the recursion if it happens but still I would like to understand what is causing it...

texx00 commented 2 years ago

Marlin should be working more or less now... Still need to try with grbl...

texx00 commented 2 years ago

I think the branch at this point is stable enough to become the alpha. Still need to verify with grbl but I do not have a device on hand to test it out... May use an arduino or an esp without drivers?

texx00 commented 2 years ago

Now the software looks stable and also the installation looks like it is working. Will test with an hwless grbl board before merging with alpha

texx00 commented 2 years ago

Still need to try out grbl but now marlin is better