tezc / sc

Common libraries and data structures for C.
BSD 3-Clause "New" or "Revised" License
2.26k stars 245 forks source link

multithreaded accept #100

Closed svladykin closed 1 year ago

svladykin commented 1 year ago

Server socket registered in multiple sc_sock_poll instances and multiple poller threads try to accept an incoming connection.

codecov[bot] commented 1 year ago

Codecov Report

Merging #100 (f80d6ab) into master (985a708) will decrease coverage by 0.04%. The diff coverage is 66.66%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/tezc/sc/pull/100/graphs/tree.svg?width=650&height=150&src=pr&token=O8ZHQ0XZ30&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ozan+Tezcan)](https://codecov.io/gh/tezc/sc/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ozan+Tezcan) ```diff @@ Coverage Diff @@ ## master #100 +/- ## ========================================== - Coverage 99.49% 99.45% -0.05% ========================================== Files 21 21 Lines 2181 2183 +2 Branches 385 386 +1 ========================================== + Hits 2170 2171 +1 Misses 3 3 - Partials 8 9 +1 ``` | [Impacted Files](https://codecov.io/gh/tezc/sc/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ozan+Tezcan) | Coverage Δ | | |---|---|---| | [socket/sc\_sock.c](https://codecov.io/gh/tezc/sc/pull/100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ozan+Tezcan#diff-c29ja2V0L3NjX3NvY2suYw==) | `98.39% <66.66%> (-0.20%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tezc/sc/pull/100?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ozan+Tezcan). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ozan+Tezcan) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tezc/sc/pull/100?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ozan+Tezcan). Last update [985a708...f80d6ab](https://codecov.io/gh/tezc/sc/pull/100?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ozan+Tezcan). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ozan+Tezcan).
svladykin commented 1 year ago

@tezc Looks like something is broken with x64-ubuntu / Clang Tidy and x64-ubuntu / Build on Ubuntu (clang), I have reverted all my changes for this PR and they are still failing.

tezc commented 1 year ago

Looks like new Clang version added some more checks. I'll fix it later today.

tezc commented 1 year ago

@svladykin Could you rebase your branch? It should be fixed now.

svladykin commented 1 year ago

@tezc Looks good now, ppc64le and s390x failures seem to be transient.