tezc / sc

Common libraries and data structures for C.

BSD 3-Clause "New" or "Revised" License

2.26k stars 245 forks source link

Build test on debug only #45

Closed tezc closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #45 (77e697a) into master (ed5bcab) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files          23       23           
  Lines        2231     2231           
  Branches      384      384           
=======================================
  Hits         2189     2189           
  Partials       42       42

Impacted Files	Coverage Δ
condition/sc_cond.c	`97.95% <ø> (ø)`
mutex/sc_mutex.c	`100.00% <ø> (ø)`
time/sc_time.c	`100.00% <ø> (ø)`
signal/sc_signal.c	`95.23% <100.00%> (ø)`
thread/sc_thread.c	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed5bcab...77e697a. Read the comment docs.

rafaeldelboni commented 3 years ago

Still getting some warnings on sc_threads

/home/delboni/Workspace/c/sc/thread/sc_thread.c: In function ‘sc_thread_start’:
/home/delboni/Workspace/c/sc/thread/sc_thread.c:127:9: error: ‘strncpy’ specified bound 128 equals destination size [-Werror=stringop-truncation]
  127 |         strncpy(thread->err, strerror(rc), sizeof(thread->err));
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/delboni/Workspace/c/sc/thread/sc_thread.c:118:9: error: ‘strncpy’ specified bound 128 equals destination size [-Werror=stringop-truncation]
  118 |         strncpy(thread->err, strerror(rc), sizeof(thread->err));
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 79%] Built target sc_option
[ 79%] Built target sc_heap
/home/delboni/Workspace/c/sc/thread/sc_thread.c: In function ‘sc_thread_join’:
/home/delboni/Workspace/c/sc/thread/sc_thread.c:147:9: error: ‘strncpy’ specified bound 128 equals destination size [-Werror=stringop-truncation]
  147 |         strncpy(thread->err, strerror(rc), sizeof(thread->err));
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

rafaeldelboni commented 3 years ago

Just add - 1 at the end of those lines:

        strncpy(thread->err, strerror(rc), sizeof(thread->err) - 1);

rafaeldelboni commented 3 years ago

You missed line 147 sc/thread/sc_thread.c:147 :)

tezc commented 3 years ago

wow, my gcc & clang don't complain about that. Probably I and CI have older versions, I'll add newer versions to CI.

rafaeldelboni commented 3 years ago

I usually have to clean the build folder or make a different one for release and debug to have these warnings showing on haha

Thanks, is working fine now!

closes #44

tezc commented 3 years ago

Thanks a lot for issue & review