Fix minor issues in sc_array

[tezc]

Fix minor issues in sc_array

• Previously, in sc_array_clear(), cap was set to zero by mistake. This bug caused an extra realloc() call on the next add call.
• Some macro parameters in sc_array used to appear twice in the code. That can have a side effect:

  #define sc_array_del(a, i)                                                     \
  do {                                                                   \
      assert((i) < (a)->size);                                       \
      const size_t _cnt = (a)->size - (i) -1;                        \
      if (_cnt > 0) {                                                \
          memmove(&((a)->elems[i]), &((a)->elems[(i) + 1]),      \
              _cnt * sizeof(*((a)->elems)));                 \
      }                                                              \
      (a)->size--;                                                   \
  } while (0)

Consider this usage: sc_array_del(arr, val++);

val will be incremented multiple time. Compilers (most if not all) will warn about this but looks like some people don't enable warnings :) Fixed the issue by pulling the variable to a local variable first.

[codecov[bot]]

Codecov Report

Merging #82 (3faf688) into master (020f6f7) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          21       21           
  Lines        2185     2185           
  Branches      382      382           
=======================================
  Hits         2181     2181           
  Partials        4        4           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 020f6f7...3faf688. Read the comment docs.