search

tezc / sc

Common libraries and data structures for C.
BSD 3-Clause "New" or "Revised" License
2.23k stars 239 forks source link

Edge-Triggered mode for sc_sock #97

Closed svladykin closed 1 year ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #97 (92b5c45) into master (53d4a91) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          21       21           
  Lines        2192     2198    +6     
  Branches      385      388    +3     
=======================================
+ Hits         2188     2194    +6     
  Partials        4        4
Impacted Files Coverage Δ
socket/sc_sock.c 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53d4a91...92b5c45. Read the comment docs.

tezc commented 2 years ago

@svladykin Thank you for the PR :) I'll be busy for the next a few days. I'll go over the PR as soon as I have some time.

tezc commented 1 year ago

@svladykin I've pushed minor changes (doc, style and a test for coverage). PR looks good to me :). It looks complete to me but is there anything else you'd like to push as part of this PR? Should we merge it?

svladykin commented 1 year ago

@tezc I think we can merge it. Thanks for reviewing!