tezoatlipoca
commented
4 months ago The tag is being clobbered.
Open tezoatlipoca opened 4 months ago
tezoatlipoca
commented
4 months ago The tag is being clobbered.
tezoatlipoca
commented
4 months ago Here's whats in the db for that entry (in markdown, copied from Edit Item page):
<div class="oposter">
<img src="https://media.mas.to/cache/accounts/avatars/109/321/701/731/047/390/original/f3f0e69d452b5eac.jpg" alt="Ned Yeung" class="opavatar">
<a href="https://mstdn.ca/@ned">Ned Yeung(ned@mstdn.ca)</a></div>
<span class="status_Content"><p>*If the minimum working wage is $2400 a month then why isn't that the minimum Canada Pension Plan?</p><p>I saw this getting shared around and had to fix it. The line, "If a high school kid flipping burgers deserves $15/hr" was incredibly infuriating and unnecessary. Why do people insist on ruining a perfectly good point by injecting pointless hatred towards others?</p><p><a href="https://mstdn.ca/tags/ubi" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>ubi</span></a> <a href="https://mstdn.ca/tags/cpp" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>cpp</span></a> <a href="https://mstdn.ca/tags/abpoli" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>abpoli</span></a> <a href="https://mstdn.ca/tags/cdnpoli" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>cdnpoli</span></a></p></span>
<span class="media_attachment"><img src="https://mas.to/media_proxy/112363899536710357/original" alt="Original meme says: If a high school kid flipping burgers deserves $15/hr ($2400 a month) then why isn't that the minimum Canada Pension Plan?
"high school kid flipping burgers deserves" is crossed out and replaced with "minimum working wage is"."></span>
<div class="importattribution">Imported from Mastodon (https://mas.to) on 5/16/2024 8:59:27 PM by tezoatlipoca@mas.to to list Tree's Bookmarks</div>And here's the written wrapper when the HTML is generated:
<span class=\"media_attachment\"><img src=\"{media.Url}\" alt=\"{media.Description}\"></span>Think: quotes and multilines in the media.Description field are borking the tag.
tezoatlipoca
commented
4 months ago Yup, its media descriptions with " characters in them. The reason we don't run into this with the main status body (err .Comment) field is we throw that through a markdown to HTML converter. But we don't sanitize the media or status card descriptions.
Here's another (that breaks the page):
<span class="media_attachment"><img src="default%20site%20title%20Tree's%20Bookmarks_files/3aa51526604a5e47.png" alt="Venn diagram of three circles reading FAST, CHEAP, and GOOD, with " lol="" nope"="" in="" the="" center"=""></span>Another one:
<div class="namecell"><a href="https://front-end.social/@sarajw/112440239248795972">https://front-end.social/@sarajw/112440239248795972</a></div>
<div class="itemrow" id="144">
<div class="commentcell overflow"><div class="oposter">
<img src="default%20site%20title%20Tree's%20Bookmarks_files/c929e49f1ccb2865.jpg" alt="Sara Joy :happy_pepper:" class="opavatar">
<a href="https://front-end.social/@sarajw">Sara Joy :happy_pepper:(sarajw@front-end.social)</a></div>
<span class="status_Content"><p>David Dylan Thomas started his closing talk strong with such a good quote.</p><p>It's still going strong.</p><p>Like his talks title says:<br>"No, seriously, fuck engagement: Building a more human web"</p><p><a href="https://front-end.social/tags/BTConf" class="mention hashtag" rel="nofollow noopener noreferrer" target="_blank">#<span>BTConf</span></a></p></span>
<span class="media_attachment"><img src="default%20site%20title%20Tree's%20Bookmarks_files/5e28a756cfe17000.jpeg" alt="David in front of his slide with the following quote:
<p>We must rapidly shift from 'thing-oriented' society to a 'person-oriented' society. When machines and computers, profit motives and property rights are considered more important than people, the giant triplets of racism, materialism, and militarism are incapable of being conquered.</p>
<p>by Dr. Martin Luther King, Jr."></span></p>
<div class=" importattribution"="">Imported from Mastodon (https://mas.to) on 5/16/2024 8:59:24 PM by tezoatlipoca@mas.to to list Tree's Bookmarks</span></div>
</div>
<div class="tagscell">
<span class="tag">btconf</span>
</div>
<div class="utilitybox">
<span class="itemmoddate">2024-05-14 15:51:32</span>
<span class="moveitemlink" style=""><a href="#" oncontextmenu="showContextMenu(event)">Move</a></span>
<span class="itemeditlink" style=""><a href="https://lists.awadwatt.com/_edit.item.html?listid=16&itemid=144">Edit</a></span>
<span class="itemdeletelink" style=""><a href="#" onclick="deleteItem(16,144); return;">Delete</a></span>
<span class="itemreportlink"><a href="#" onclick="reportItem(16,144); return;">Report</a></span>
</div>
</div>
Example: