search

tezos-checker / checker

An in-development "robocoin" system for the Tezos blockchain
24 stars 16 forks source link

Missing tests for liquidation cancellation #153

Open gkaracha opened 3 years ago

gkaracha commented 3 years ago

Due to the specific conditions needed for the cancellation of a liquidation, we currently have no test where Checker.entrypoint_cancel_liquidation_slice succeeds in returning a liquidation slice back to its burrow. Now that it's been getting easier to write e2e tests it's probably time to add tests for more intricate scenaria where cancellation is possible.

dorranh commented 3 years ago

@gkaracha, would you consider this issue resolved after #193, or would you prefer that we add additional tests for this case?

gkaracha commented 3 years ago

@dorranh As far as the e2e tests are concerned I do consider it resolved indeed! I would still like us to be able to expand our tests on the OCaml side though (see discussion with @utdemir here: https://github.com/tezos-checker/checker/pull/195#pullrequestreview-705694421). We could resolve this issue and open another one, though I think I'd just leave this one open instead.