Closed gkaracha closed 3 years ago
The removal of error_SellKitTooMuchTezBought
and error_BuyKitTooMuchKitBought
lead to a slight bytecode size reduction as well:
< buy_kit: ~1518 bytes, 1 chunks
> buy_kit: ~1472 bytes, 1 chunks
< sell_kit: ~1518 bytes, 1 chunks
> sell_kit: ~1472 bytes, 1 chunks
Total bytecode size reduction:
< buy_kit: ~1518 bytes, 1 chunks
> buy_kit: ~1472 bytes, 1 chunks
< sell_kit: ~1518 bytes, 1 chunks
> sell_kit: ~1472 bytes, 1 chunks
< add_liquidity: ~2169 bytes, 1 chunks
> add_liquidity: ~2131 bytes, 1 chunks
< remove_liquidity: ~2311 bytes, 1 chunks
> remove_liquidity: ~2223 bytes, 1 chunks
Coverage increases
error_SellKitTooMuchTezBought
error_BuyKitTooMuchKitBought
error_AddLiquidityZeroKitDeposited
error_RemoveLiquidityTooMuchTezWithdrawn
error_RemoveLiquidityTooMuchKitWithdrawn
Note that
cfmm.ml
has been and still is reported as having 100% test coverage bybisect_ppx
, but before this PR it was at 92.31% real.I think that with this PR we get to an actual 100%, but to check that I have to manually switch theI (painstakingly) checked and we are now at real 100% coverage forif-then-else
s tomatch-with
s at the moment.cfmm.ml
.