Closed dorranh closed 3 years ago
Looks like the end to end tests are a bit flaky :slightly_frowning_face:. Investigating this further before we should consider merging.
Gas costs | a253e3e8a8a5fa2d5a4deaeff8a62913a9446f08 | e8e319fe309c36bf0ce4f2d6a5a1bda8867d4531 | Diff |
---|---|---|---|
checker%touch | None | 30471 | 30471 |
touch | 30471 | None | -30471 |
tezWrapper%withdraw | None | 14410 | 14410 |
tezWrapper%deposit | None | 13490 | 13490 |
tezWrapper%set_delegate | None | 12880 | 12880 |
checker%add_liquidity | None | 12654 | 12654 |
add_liquidity | 12654 | None | -12654 |
tezWrapper%transfer | None | 12609 | 12609 |
remove_liquidity | 12584 | None | -12584 |
checker%remove_liquidity | None | 12584 | 12584 |
buy_kit | 12502 | None | -12502 |
checker%buy_kit | None | 12502 | 12502 |
sell_kit | 11734 | None | -11734 |
checker%sell_kit | None | 11734 | 11734 |
deactivate_burrow | 11279 | None | -11279 |
checker%deactivate_burrow | None | 11279 | 11279 |
checker%withdraw_collateral | None | 11133 | 11133 |
withdraw_collateral | 11133 | None | -11133 |
checker%set_burrow_delegate | None | 9836 | 9836 |
set_burrow_delegate | 9836 | None | -9836 |
activate_burrow | 8921 | None | -8921 |
checker%activate_burrow | None | 8921 | 8921 |
deposit_collateral | 8901 | None | -8901 |
checker%deposit_collateral | None | 8901 | 8901 |
checker%burn_kit | None | 7154 | 7154 |
burn_kit | 7154 | None | -7154 |
checker%mint_kit | None | 6926 | 6926 |
mint_kit | 6926 | None | -6926 |
checker%create_burrow | None | 6915 | 6915 |
create_burrow | 6915 | None | -6915 |
transfer | 6131 | None | -6131 |
checker%transfer | None | 6131 | 6131 |
checker%touch_burrow | None | 5922 | 5922 |
touch_burrow | 5921 | None | -5921 |
checker%update_operators | None | 5410 | 5410 |
update_operators | 5410 | None | -5410 |
tezWrapper%update_operators | None | 4053 | 4053 |
Entrypoint sizes: No change. Test coverage: No change.
Well, I got it fixed. Turns out I hadn't pulled the bug fix for the wrapper from last week before creating this branch :facepalm:
Gas costs | a253e3e8a8a5fa2d5a4deaeff8a62913a9446f08 | 94b5e48be90f02ed0b9ad2b0b0fad2da51ed128f | Diff |
---|---|---|---|
touch | 30471 | None | -30471 |
checker%touch | None | 30471 | 30471 |
tezWrapper%withdraw | None | 14410 | 14410 |
tezWrapper%deposit | None | 13490 | 13490 |
tezWrapper%set_delegate | None | 12880 | 12880 |
add_liquidity | 12654 | None | -12654 |
checker%add_liquidity | None | 12654 | 12654 |
tezWrapper%transfer | None | 12609 | 12609 |
checker%remove_liquidity | None | 12584 | 12584 |
remove_liquidity | 12584 | None | -12584 |
buy_kit | 12502 | None | -12502 |
checker%buy_kit | None | 12502 | 12502 |
sell_kit | 11734 | None | -11734 |
checker%sell_kit | None | 11734 | 11734 |
deactivate_burrow | 11279 | None | -11279 |
checker%deactivate_burrow | None | 11279 | 11279 |
checker%withdraw_collateral | None | 11133 | 11133 |
withdraw_collateral | 11133 | None | -11133 |
set_burrow_delegate | 9836 | None | -9836 |
checker%set_burrow_delegate | None | 9836 | 9836 |
checker%activate_burrow | None | 8921 | 8921 |
activate_burrow | 8921 | None | -8921 |
checker%deposit_collateral | None | 8901 | 8901 |
deposit_collateral | 8901 | None | -8901 |
checker%burn_kit | None | 7154 | 7154 |
burn_kit | 7154 | None | -7154 |
checker%mint_kit | None | 6926 | 6926 |
mint_kit | 6926 | None | -6926 |
create_burrow | 6915 | None | -6915 |
checker%create_burrow | None | 6915 | 6915 |
checker%transfer | None | 6131 | 6131 |
transfer | 6131 | None | -6131 |
touch_burrow | 5921 | None | -5921 |
checker%touch_burrow | None | 5921 | 5921 |
checker%update_operators | None | 5410 | 5410 |
update_operators | 5410 | None | -5410 |
tezWrapper%update_operators | None | 4053 | 4053 |
Entrypoint sizes: No change. Test coverage: No change.
Adds end to end tests which call all of the tez wrapper's entrypoints. In order to avoid further changes to our bot, etc. I updated the end to end tests to merge their gas costs, adding an identifier before each entrypoint (e.g.
checker%mint_kit
) to distinguish between overlapping entrypoint names. This might cause the github actions bot to produce some weird diff messages for this PR.Closes #267