search

tezos-checker / checker

An in-development "robocoin" system for the Tezos blockchain
24 stars 16 forks source link

Potential security vulnerabilities in the python dependencies #278

Closed gkaracha closed 2 years ago

gkaracha commented 3 years ago

Since #272 was merged I've been seeing the following Dependabot warning:

We found potential security vulnerabilities in your dependencies.

The warning refers to two python dependencies in our poetry.lock:

We should probably fix that.

dorranh commented 3 years ago

The first point is actually a bit blocked by pytezos which pins an older version of fastecdsa. We can hack around that need be, but the cleaner solution is to upgrade it upstream. I created an issue for this here: https://github.com/baking-bad/pytezos/issues/261

dorranh commented 3 years ago

The pywin32 one is an issue with both our version of docker-py and that used by pytezos. However, we can't bump our docker-py version to the latest release (5.0.3) until pytezos upgrades since pytezos places an upper bound of <5.0.0.

dorranh commented 2 years ago

Note: the pywin32 vulnerability is blocked on https://github.com/docker/docker-py/pull/2925.

dorranh commented 2 years ago

After reviewing the pywin32 vulnerability a bit more, it seems that this should only affect people running checker's python applications directly on Windows (i.e. on the Windows host itself and not from within a Docker container running on Windows). Since very few of the tools in our stack are supported on Windows, I'm going to go ahead and dismiss that alert. Please feel free to re-open though.

gkaracha commented 2 years ago

Sounds good to me! :+1: