Closed gkaracha closed 3 years ago
mockFA2
(#288) might also fall into this category, even if it is to be used only for testing purposes.
After having another look at this issue I think we need the following to be able to close the issue:
TezWrapper.tez_token_id
, Wctez.wctez_token_id
, and MockFA2.token_id
and instead have them generated at build time from the checker.yaml
file (tokens.issued.wtez.token_id
, tokens.issued.wctez.token_id
, and tokens.issued.mock_fa2.token_id
, respectively).src/tokenMetadata.ml
which is generated at build time and have them all be available there.token_id
s; these should also be taken from the yaml file.
In principle, all configuration should come from
checker.yaml
. Currently we have a mix of hard-wired and configurable information, which can easily get out of sync. Taken from https://github.com/tezos-checker/checker/pull/290#issuecomment-964113677:Let's have all token information come from
checker.yaml
, even for those tokens that are conditionally generated (bothwctez
andtezWrapper
are needed whencollateral = TEZ
, which is the only case at the moment).