Closed gkaracha closed 3 years ago
Gas costs | 32dcc6135ebec83a96edd3ee221bebbb0f01a42c | b90734f39554a3d11b4e52ce072c39f3e8608812 | Diff |
---|---|---|---|
tezWrapper%transfer | 12610 | None | -12610 |
wtez%transfer | None | 12610 | 12610 |
tezWrapper%withdraw | 9758 | None | -9758 |
wtez%withdraw | None | 9758 | 9758 |
wtez%set_delegate | None | 8293 | 8293 |
tezWrapper%set_delegate | 8293 | None | -8293 |
wtez%deposit | None | 7373 | 7373 |
tezWrapper%deposit | 7373 | None | -7373 |
wtez%update_operators | None | 4054 | 4054 |
tezWrapper%update_operators | 4054 | None | -4054 |
mockFA2%redeem | 3554 | 3552 | -2 |
mockFA2%update_operators | 3201 | 3199 | -2 |
mockFA2%transfer | 4659 | 4657 | -2 |
mockFA2%mint | 3319 | 3317 | -2 |
Entrypoint sizes: No change. | Test coverage | 32dcc6135ebec83a96edd3ee221bebbb0f01a42c | b90734f39554a3d11b4e52ce072c39f3e8608812 | Diff |
---|---|---|---|---|
tokenMetadata.ml | None | 100 | 100 | |
ctok.ml | 74.36 | 72.97 | -1.3900000000000006 | |
lqt.ml | 74.36 | 72.97 | -1.3900000000000006 | |
tok.ml | 79.49 | 78.38 | -1.1099999999999994 | |
TOTAL | 92.45 | 92.47 | 0.01999999999999602 |
Gas costs | 32dcc6135ebec83a96edd3ee221bebbb0f01a42c | 06bfc39b9695cc6d55308ede7363555d28268a73 | Diff |
---|---|---|---|
tezWrapper%transfer | 12610 | None | -12610 |
wtez%transfer | None | 12610 | 12610 |
tezWrapper%withdraw | 9758 | None | -9758 |
wtez%withdraw | None | 9758 | 9758 |
tezWrapper%set_delegate | 8293 | None | -8293 |
wtez%set_delegate | None | 8293 | 8293 |
tezWrapper%deposit | 7373 | None | -7373 |
wtez%deposit | None | 7373 | 7373 |
tezWrapper%update_operators | 4054 | None | -4054 |
wtez%update_operators | None | 4054 | 4054 |
mockFA2%update_operators | 3201 | 3199 | -2 |
mockFA2%transfer | 4659 | 4657 | -2 |
mockFA2%redeem | 3554 | 3552 | -2 |
mockFA2%mint | 3319 | 3317 | -2 |
Entrypoint sizes: No change. | Test coverage | 32dcc6135ebec83a96edd3ee221bebbb0f01a42c | 06bfc39b9695cc6d55308ede7363555d28268a73 | Diff |
---|---|---|---|---|
tokenMetadata.ml | None | 100 | 100 | |
ctok.ml | 74.36 | 72.97 | -1.3900000000000006 | |
lqt.ml | 74.36 | 72.97 | -1.3900000000000006 | |
tok.ml | 79.49 | 78.38 | -1.1099999999999994 | |
TOTAL | 92.45 | 92.47 | 0.01999999999999602 |
Gas costs | 32dcc6135ebec83a96edd3ee221bebbb0f01a42c | 296383063ee34f8fe52b8f985bb2f151ab59c326 | Diff |
---|---|---|---|
wtez%transfer | None | 12610 | 12610 |
tezWrapper%transfer | 12610 | None | -12610 |
tezWrapper%withdraw | 9758 | None | -9758 |
wtez%withdraw | None | 9758 | 9758 |
tezWrapper%set_delegate | 8293 | None | -8293 |
wtez%set_delegate | None | 8293 | 8293 |
tezWrapper%deposit | 7373 | None | -7373 |
wtez%deposit | None | 7373 | 7373 |
tezWrapper%update_operators | 4054 | None | -4054 |
wtez%update_operators | None | 4054 | 4054 |
mockFA2%redeem | 3554 | 3552 | -2 |
mockFA2%transfer | 4659 | 4657 | -2 |
mockFA2%mint | 3319 | 3317 | -2 |
mockFA2%update_operators | 3201 | 3199 | -2 |
Entrypoint sizes: No change. | Test coverage | 32dcc6135ebec83a96edd3ee221bebbb0f01a42c | 296383063ee34f8fe52b8f985bb2f151ab59c326 | Diff |
---|---|---|---|---|
tokenMetadata.ml | None | 100 | 100 | |
lqt.ml | 74.36 | 72.97 | -1.3900000000000006 | |
ctok.ml | 74.36 | 72.97 | -1.3900000000000006 | |
tok.ml | 79.49 | 78.38 | -1.1099999999999994 | |
TOTAL | 92.45 | 92.47 | 0.01999999999999602 |
Great, thanks! I addressed your comment; I shall merge once CI is green :slightly_smiling_face:
Gas costs | 32dcc6135ebec83a96edd3ee221bebbb0f01a42c | bd8a9fbdb7e817f8ae60d7b9ba2af6627a803f23 | Diff |
---|---|---|---|
tezWrapper%transfer | 12610 | None | -12610 |
wtez%transfer | None | 12610 | 12610 |
wtez%withdraw | None | 9758 | 9758 |
tezWrapper%withdraw | 9758 | None | -9758 |
tezWrapper%set_delegate | 8293 | None | -8293 |
wtez%set_delegate | None | 8293 | 8293 |
tezWrapper%deposit | 7373 | None | -7373 |
wtez%deposit | None | 7373 | 7373 |
tezWrapper%update_operators | 4054 | None | -4054 |
wtez%update_operators | None | 4054 | 4054 |
mockFA2%transfer | 4659 | 4657 | -2 |
mockFA2%mint | 3319 | 3317 | -2 |
mockFA2%redeem | 3554 | 3552 | -2 |
mockFA2%update_operators | 3201 | 3199 | -2 |
Entrypoint sizes: No change. | Test coverage | 32dcc6135ebec83a96edd3ee221bebbb0f01a42c | bd8a9fbdb7e817f8ae60d7b9ba2af6627a803f23 | Diff |
---|---|---|---|---|
tokenMetadata.ml | None | 100 | 100 | |
lqt.ml | 74.36 | 72.97 | -1.3900000000000006 | |
ctok.ml | 74.36 | 72.97 | -1.3900000000000006 | |
tok.ml | 79.49 | 78.38 | -1.1099999999999994 | |
TOTAL | 92.45 | 92.47 | 0.01999999999999602 |
Closes #291.
Turning this into a PR early, to see if there are any unexpected gas cost changes due to the new module dependency graph.
Apart from the main change (i.e., moving
token_id
s andtoken_decimal_digits
into a dynamically generated file), this PR also implements some small renamings in the relevant files, for uniformity. (A bug was also found in mockFA2 module, in the process.)REMAINING TODO: UpdateAddressed.e2e/main.py
; this is the only remaining file that hardcodes some token_ids.