Ensure that `earthly +test` and `earthly +test-e2e` work with both collateral configurations

gkaracha commented 3 years ago

Create default configurations checker-tez.yaml and checker-fa2.yaml. At build/deployment time we can just copy the one we wish to use into checker.yaml.
Fix references to the wrong token id in WTezTest.
Patch the end-to-end tests so that they can function under both configurations for collateral_type.
Comment out a couple of tight unit tests that emit different operations under different configurations. (Ideally we'd re-enable these tests and have two separate testsuites, one per collateral type).

While updating client/checker_client/cli.py I also noticed that the commands for deployment we currently have in the README.md don't work on my machine due to a failure to deploy ctez's CFMM. This needs further investigation.

github-actions[bot] commented 3 years ago

Gas costs	77fe37617d4f8bc493aa6e7716e557a78afae024	d14d9281b4938d60640887df6a9b44bd052585fb	Diff
checker%set_burrow_delegate	18304	None	-18304

Entrypoint sizes: No change. Test coverage: No change.

github-actions[bot] commented 3 years ago

Gas costs	77fe37617d4f8bc493aa6e7716e557a78afae024	dc519f16e2d527f9a0f3b8683ce4bccd66147745	Diff
checker%buy_kit	12420	12421	1

Entrypoint sizes: No change. Test coverage: No change.

gkaracha commented 3 years ago

I'll go ahead and merge this one. It'd be nice to have CI use the two default configurations (as I crudely tried on 312ebe0737e692a039b8daa43eeea541045c8f37) but CI hours effectively double and I'm not sure whether that's OK. At least after merging this PR we can do that locally when we need to :slightly_smiling_face:

cp checker-fa2.yaml checker.yaml && earthly +build-ocaml

tezos-checker / checker

Ensure that `earthly +test` and `earthly +test-e2e` work with both collateral configurations #301