search

tezos-checker / checker

An in-development "robocoin" system for the Tezos blockchain
24 stars 16 forks source link

Support for non-root user in dev container #309

Closed dorranh closed 2 years ago

dorranh commented 2 years ago

Updates the dev container to use a non-root user. This avoid situations where artifacts created in a volume mount require a sudo chown command or similar on the host since they were created using the root user in the container.

In order to accomplish this, I had to expand the entrypoint script a bit to enable re-mapping of the user and docker group within the container at runtime so that they match the respective ids on the host. This requires setting two extra environment variables when launching the contianer, and I updated the README with the new command.

To test locally you will first need to run: earthly +dev-container

Then modify the command in the README to point to the new local image you just created: checker/dev:latest

github-actions[bot] commented 2 years ago
Gas costs: No change. Entrypoint sizes 2f97225f5b7ae9e5d7315a13563582fe277ccf05 3da8a6d356763be26ad986c177b9f0b59024f3be Diff
touch 56749 56556 -193
Test coverage 2f97225f5b7ae9e5d7315a13563582fe277ccf05 3da8a6d356763be26ad986c177b9f0b59024f3be Diff
price.ml 76.92 100 23.08
TOTAL 92.47 92.57 0.09999999999999432
gkaracha commented 2 years ago

Hey, sorry it took me a little while to get to this. Just rebased it since Earthfile had changed a little in the meantime, I'll try it out now and get back to you.

github-actions[bot] commented 2 years ago
Gas costs a678ae19ba017cf225483f16f66ebef6a6b06a51 1af568a3ac85142a9ef645de5c83a5e11a6a4ee5 Diff
checker%set_burrow_delegate 18365 None -18365
checker%touch 42390 30897 -11493
checker%create_burrow 22343 12605 -9738
checker%withdraw_collateral 23080 14870 -8210
checker%deposit_collateral 20046 11836 -8210
checker%deactivate_burrow 23439 15229 -8210
checker%activate_burrow 19862 11652 -8210
mock_fa2%mint None 3691 3691
mock_fa2%update_operators None 3338 3338
checker%sell_kit 12446 12297 -149
checker%add_liquidity 12599 12451 -148
checker%remove_liquidity 13295 13147 -148
checker%buy_kit 12446 12298 -148
checker%update_operators 5589 5586 -3
checker%touch_burrow 6102 6099 -3
checker%transfer 6311 6308 -3

Entrypoint sizes: No change. Test coverage: No change.

gkaracha commented 2 years ago

PS. I think that the message bot is going crazy :sweat_smile:

dorranh commented 2 years ago

Nice, I'm glad to hear it! I'll go ahead and merge.

PS. I think that the message bot is going crazy

Ya, I think it might need to take some time off for the holidays as well...