tezos-commons / baseDAO

BaseDAO - a generic smart contract framework for DAOs on Tezos
57 stars 15 forks source link

Include token_id in the sender check during transfer calls #203

Closed sras closed 3 years ago

sras commented 3 years ago

Clarification and motivation

In #54 we added support for multiple token_ids other than the frozen token. This means that as per FA2, operators should be tracked for each token_id. But as of now, we do not include this information in the operators structure. We should include token_id in the operators and use it to check that the operator is allowed to transfer token_ids in the request.

Acceptance criteria

  1. operators include token_id along with operator address, indicating the token_ids a certain operator is allowed to transfer for the ower.
  2. During transfers, we should check that the sender is a valid operator by including token_id in the check.