tezos-commons / baseDAO

BaseDAO - a generic smart contract framework for DAOs on Tezos
57 stars 15 forks source link

[#208] Remove the `mint` entrypoint #217

Closed rinn7e closed 3 years ago

rinn7e commented 3 years ago

Description

Problem: mint is an admin-only entrypoint that allow generating tokens. This was intended to be used mainly to set up the contract and then to not be used again. However, it is possible to setup the ledger with correct initial value at origination and we no longer need this entrypoint.

Solution: Remove mint entrypoint and remove all related tests.

Related issue(s)

Resolves #208

:white_check_mark: Checklist for your Pull Request

Related changes (conditional)

Stylistic guide (mandatory)

rinn7e commented 3 years ago

@pasqu4le I decide to combine these 2 issues into 1 PR since they are related. Hope to get your review on this.

The only note is that, I do not make the changes to lorentz version. Let me know if you want me to update it as well.

rinn7e commented 3 years ago

@pasqu4le I decide to combine these 2 issues into 1 PR since they are related. Hope to get your review on this.

The only note is that, I do not make the changes to lorentz version. Let me know if you want me to update it as well.

So I decide to split this after all. Here is for the burn: https://github.com/tqtezos/baseDAO/pull/218 @sras Hope to get your review on both of these as well.

pasqu4le commented 3 years ago

I do not make the changes to lorentz version.

No, that won't be necessary, this is Ligo-only once again.

pasqu4le commented 3 years ago

Ah one minor thing, please make the commit message changes I explained in the other issue comment here as well.