tezos-commons / baseDAO

BaseDAO - a generic smart contract framework for DAOs on Tezos
57 stars 15 forks source link

[#214] Remove `get_total_supply` and `get_vote_permit_counter` #224

Closed rinn7e closed 3 years ago

rinn7e commented 3 years ago

Description

Problem: After #166, we no longer need get_total_supply and get_vote_permit_counter entrypoints. We updated it to void instead of removing because the tests need them to run properly. Currently, we found a way to check the storage without using this entrypoints (By using StorageView instead) so we should remove these entrypoints.

Solution: Remove get_total_supply and get_vote_permit_counter entrypoints, add FullStorageView, update existing storage related type, add getTotalSupply and getVotePermitsCounter storage check.

Related issue(s)

Resolves #214

:white_check_mark: Checklist for your Pull Request

Related changes (conditional)

Stylistic guide (mandatory)