tezos-commons / baseDAO

BaseDAO - a generic smart contract framework for DAOs on Tezos
57 stars 15 forks source link

[#257] Prevent empty transactions in transfer proposals #268

Closed rinn7e closed 3 years ago

rinn7e commented 3 years ago

Description

Problem: Both treasuryDAO and registryDAO have proposals that can support xtz transfers. Both implement handle_transfer for Xtz_transfer_type in a way that can fail: empty transactions (of unit parameter an 0 amount) will be rejected by the network.

Solution: proposal_check now reject proposal that contains Xtz_transfer_type with 0 mutez, add tests to cover this.

Related issue(s)

Resolves #257

:white_check_mark: Checklist for your Pull Request

Related changes (conditional)

Stylistic guide (mandatory)