Problem: Both treasuryDAO and registryDAO have proposals
that can support xtz transfers.
Both implement handle_transfer for Xtz_transfer_type in a way
that can fail: empty transactions (of unit parameter an 0 amount)
will be rejected by the network.
Solution: proposal_check now reject proposal that contains
Xtz_transfer_type with 0 mutez, add tests to cover this.
Related issue(s)
Resolves #257
:white_check_mark: Checklist for your Pull Request
Related changes (conditional)
Tests
[x] If I added new functionality, I added tests covering it.
[x] If I fixed a bug, I added a regression test to prevent the bug from
silently reappearing again.
Documentation
[x] I checked whether I should update the docs and did so if necessary:
Description
Problem: Both
treasuryDAO
andregistryDAO
have proposals that can support xtz transfers. Both implementhandle_transfer
forXtz_transfer_type
in a way that can fail: empty transactions (ofunit
parameter an0
amount) will be rejected by the network.Solution:
proposal_check
now reject proposal that containsXtz_transfer_type
with 0 mutez, add tests to cover this.Related issue(s)
Resolves #257
:white_check_mark: Checklist for your Pull Request
Related changes (conditional)
Tests
Documentation
Stylistic guide (mandatory)