Problem: Both registryDAO and treasuryDAO have a proposal_check
lambda that is meant to check some conditions to approve/discard
submitted proposals.
Tests on such checks however are a bit lacking and don't cover all the
cases of possible failure and corner cases (including possible lack of failures).
Solution: Update proposal_check to throw clearer error messages, add
more tests to handle all possible cases.
Related issue(s)
Resolves #260
:white_check_mark: Checklist for your Pull Request
Related changes (conditional)
Tests
[x] If I added new functionality, I added tests covering it.
[x] If I fixed a bug, I added a regression test to prevent the bug from
silently reappearing again.
Documentation
[x] I checked whether I should update the docs and did so if necessary:
Description
Problem: Both
registryDAO
andtreasuryDAO
have aproposal_check
lambda that is meant to check some conditions to approve/discard submitted proposals. Tests on such checks however are a bit lacking and don't cover all the cases of possible failure and corner cases (including possible lack of failures).Solution: Update
proposal_check
to throw clearer error messages, add more tests to handle all possible cases.Related issue(s)
Resolves #260
:white_check_mark: Checklist for your Pull Request
Related changes (conditional)
Tests
Documentation
Stylistic guide (mandatory)