tezos-commons / baseDAO

BaseDAO - a generic smart contract framework for DAOs on Tezos
57 stars 15 forks source link

[#260] Throw better errors in `proposal_check`, add more tests #273

Closed rinn7e closed 3 years ago

rinn7e commented 3 years ago

Description

Problem: Both registryDAO and treasuryDAO have a proposal_check lambda that is meant to check some conditions to approve/discard submitted proposals. Tests on such checks however are a bit lacking and don't cover all the cases of possible failure and corner cases (including possible lack of failures).

Solution: Update proposal_check to throw clearer error messages, add more tests to handle all possible cases.

Related issue(s)

Resolves #260

:white_check_mark: Checklist for your Pull Request

Related changes (conditional)

Stylistic guide (mandatory)