Problem: It seems that we don't actually check the
'proposal_key_list_sort_by_date' structure for the proposal existence
check. And we should since we only remove proposals from this set during
proposal flush/delete operations.
Solution: In additon to the check in proposals bigmap, check if
'proposal_key_list_sort_by_date' also contains the proposal before
returning success. Add some tests that it works as expected.
Related issue(s)
Resolves #290
:white_check_mark: Checklist for your Pull Request
Related changes (conditional)
Tests
[x] If I added new functionality, I added tests covering it.
[x] If I fixed a bug, I added a regression test to prevent the bug from
silently reappearing again.
Documentation
[x] I checked whether I should update the docs and did so if necessary:
Description
Problem: It seems that we don't actually check the 'proposal_key_list_sort_by_date' structure for the proposal existence check. And we should since we only remove proposals from this set during proposal flush/delete operations.
Solution: In additon to the check in proposals bigmap, check if 'proposal_key_list_sort_by_date' also contains the proposal before returning success. Add some tests that it works as expected.
Related issue(s)
Resolves #290
:white_check_mark: Checklist for your Pull Request
Related changes (conditional)
Tests
Documentation
Stylistic guide (mandatory)