tezos-reward-distributor-organization / tezos-reward-distributor

Tezos Reward Distributor (TRD): A reward distribution software for tezos bakers.
https://tezos-reward-distributor-organization.github.io/tezos-reward-distributor/
GNU General Public License v3.0
88 stars 50 forks source link

Suggestions for Simplification #542

Open decentralgabe opened 2 years ago

decentralgabe commented 2 years ago

Describe the solution you'd like

Config

  1. Combine founders_map and owners_map. I'm curious how necessary having both is. I can see a potential argument made for bakers that have both founders and owners wanting to first compensate founders, and then owners. Do people actually use that? Could they be combined?
  2. Combine specials_map and supporters_set. The only real difference here is the implicit 0 service fee, which could be set manually in the specials_map.

Misc

Can the Dexter code be removed? Does Dexter exist anymore?

ericlavoie commented 2 years ago

Founders_map and Owners_map. It is needed to be separate, founders refers to the distribution ratio for the service fees collected (fees the bakers charge) the owners map distributes the rewards for funds according to the ratio that was contributed by each owner. I actually use it personally. It is for tax reason we split service fees a different way.

Read carefully the documentation. Special maps and supported set could be, by setting it to 0, the pain versus the gain of removing the correct reference in the code, may not had more functionality, and may be detrimental for older installation, you will have to retain backward compatibility for all config that use it.

decentralgabe commented 2 years ago

thanks for the input. I did read the documentation but had to read it 2-3 times to fully understand it.

ericlavoie commented 2 years ago

It took me a few read.