tezos-reward-distributor-organization / tezos-reward-distributor

Tezos Reward Distributor (TRD): A reward distribution software for tezos bakers.
https://tezos-reward-distributor-organization.github.io/tezos-reward-distributor/
GNU General Public License v3.0
87 stars 50 forks source link

Use TRD in dryrun without signer #614

Closed redref closed 1 year ago

redref commented 2 years ago

Description When using TRD in dryrun mode, signer configuration is still required to validate payment address.

To Reproduce Start TRD in dryrun without signer started or configured with payment address key.

Expected behavior Should compute payments and stats without halting.

Environment

nicolasochem commented 2 years ago

First and most importantly: thank you for this contribution.

I missed the train on this one but it's important to test signing when in dry-run mode.

Signing can go wrong for a variety of reasons, tezos has many different signer implementations, so it is really important for dry run to test the entire stack, which includes signing, and stop right before injection.

Arguably it's dangerous to sign operations because they can be replayed later. And the original issue is valid: when trying payouts with ledger for example, it's annoying to have to plug it, unlock it, just to see how much you are going to pay out.

Can we sign by default in dry-run and have a --dry-run-no-signing flag?

redref commented 2 years ago

I tend to agree with you on the "dryrun should sign and drop before injection".

On the other end, modification was only about checking key exists in signer. Signature itself is not impacted (but I am not sure it signs in dryrun).

I am not sure I understand well enough to check and do modifications if needed.