Closed redref closed 1 year ago
name: Do not check signer/validate address in dry run mode
This PR resolves the issue #614 . The following steps were performed:
Analysis: During initialization, TRD checks key is present in signer but in my POV, should not use it in dryrun mode.
Solution: Forward dryrun flag to configuration loading and do not validate in this case.
Implementation: N/A
Performed tests: Running on my side to provide stats and payments CSVs (in another security context than the baker)
Documentation: Please let me know if something needs to be done here.
Check list: Please let me know if something needs to be done here.
Work effort: 1h
Updated to fix linter.
I am trying to think hard if there could be any issue with this... but I think it is straight forward and you are right that this check is annoying :)
Please fill out your name here
name: Do not check signer/validate address in dry run mode
This PR resolves the issue #614 . The following steps were performed:
Analysis: During initialization, TRD checks key is present in signer but in my POV, should not use it in dryrun mode.
Solution: Forward dryrun flag to configuration loading and do not validate in this case.
Implementation: N/A
Performed tests: Running on my side to provide stats and payments CSVs (in another security context than the baker)
Documentation: Please let me know if something needs to be done here.
Check list: Please let me know if something needs to be done here.
Work effort: 1h