Closed AndrewKishino closed 1 year ago
fix confirmed by @dansan566
@AndrewKishino please fix lint and test PLUS add your name and tz address to the contributors.csv - good to merge afterwards
I will add up to 1h. Can you please make a separate PR for your tz address in the CSV file?
name: Bugfix for
consumed_gas
calculation after Kathmandu upgrade about:consumed_gas
is deprecated in favor ofconsumed_milligas
for gas calculations. labels: gas-calculationIMPORTANT NOTICE: I read and understood the guidelines for contributions to the TRD. The contribution may qualify for being compensated by the TRD grant if approved by the maintainers.
This PR resolves the issue. The following steps were performed:
Analysis: After the Kathmandu update, payments to KT accounts were failing due to gas consumption simulations. The reason is because
consumed_gas
is deprecated in favor ofconsumed_milligas
.Solution:
consumed_gas
is deprecated in favor ofconsumed_milligas
for gas calculations. To achieve parity, we need to calculate theconsumed_gas
by dividingconsumed_milligas
by1000
Implementation: Calculate
consumed_gas
fromconsumed_milligas
Performed tests: Manually ran payments on Ghostnet with KT delegators
Documentation: Make sure to document the added changes in a proper way (Readme, help section, documentation, comments in code if needed)
Check list:
[ ] I extended the Github Actions CI test units with the corresponding tests for this new feature (if needed).
[ ] I extended the Sphinx documentation (if needed).
[ ] I extended the help section (if needed).
[ ] I changed the README file (if needed).
[ ] I created a new issue if there is further work left to be done (if needed).
Work effort: 1hrs (edit jdsika)