tezos-reward-distributor-organization / tezos-reward-distributor

Tezos Reward Distributor (TRD): A reward distribution software for tezos bakers.
https://tezos-reward-distributor-organization.github.io/tezos-reward-distributor/
GNU General Public License v3.0
87 stars 51 forks source link

uncaught payout failures #621

Open nicolasochem opened 1 year ago

nicolasochem commented 1 year ago

Follow up from #619

In kathmandu, some rpc fields changed names resulting in a python exception when calculating payouts.

The exception was inproperly caught, resulting the failed payouts to NOT be listed in the failed folder. Instead, they were listed in the done folder with a status of undefined.

We are missing a try/catch somewhere, so when such errors happen, we mark payout as failed, and an updated TRD can then reprocess the payouts without needing to manipulate files by hand.

To replicate: