tezos-reward-distributor-organization / tezos-reward-distributor

Tezos Reward Distributor (TRD): A reward distribution software for tezos bakers.
https://tezos-reward-distributor-organization.github.io/tezos-reward-distributor/
GNU General Public License v3.0
87 stars 51 forks source link

feat: allow user to run a dryrun with and without a signer #625

Closed rvermootenct closed 1 year ago

rvermootenct commented 1 year ago

name: Allow user to run dry run with and without a signer about: A user girl should be able to decide if she wants to run dry mode with or without a signer present. labels:


IMPORTANT NOTICE: I read and understood the guidelines for contributions to the TRD. The contribution may qualify for being compensated by the TRD grant if approved by the maintainers.

This PR resolves the issue 614. The following steps were performed:

Work effort: 1

jdsika commented 1 year ago

Please add your tz address and GitHub username in the contributors.csv

jdsika commented 1 year ago

This is an interesting situation. We add a new feature and I start to wonder on compatibility issues and how the combinations. It would be great if you could spend some effort on defining tests for these parameters that would give me confidence in the functionality and also help me to understand the impact on TRD

nicolasochem commented 1 year ago

Nice PR!

jdsika commented 1 year ago

replaced by #631