Closed rvermootenct closed 1 year ago
Please add your tz address and GitHub username in the contributors.csv
This is an interesting situation. We add a new feature and I start to wonder on compatibility issues and how the combinations. It would be great if you could spend some effort on defining tests for these parameters that would give me confidence in the functionality and also help me to understand the impact on TRD
Nice PR!
replaced by #631
name: Allow user to run dry run with and without a signer about: A user girl should be able to decide if she wants to run dry mode with or without a signer present. labels:
IMPORTANT NOTICE: I read and understood the guidelines for contributions to the TRD. The contribution may qualify for being compensated by the TRD grant if approved by the maintainers.
This PR resolves the issue 614. The following steps were performed:
Analysis: It was determined that there are cases where it is both helpful and annoying to have to use a signer during dry run mode.
Solution: Allow a user girl to decide whether she would like to use a signer or not depending on their use case.
Implementation: Move what had been done in PR 615 into its own option, allowing dry run to stay as it was before.
Performed tests: Ran dry run and dry run no signer locally.![](https://media.giphy.com/media/79icA8iD6PPutlQa6j/giphy.gif)
Documentation: Updated the help documentation,
Check list:
[ ] I extended the Github Actions CI test units with the corresponding tests for this new feature (if needed).
[ ] I extended the Sphinx documentation (if needed).
[x] I extended the help section (if needed).
[ ] I changed the README file (if needed).
[ ] I created a new issue if there is further work left to be done (if needed).
Work effort: 1