Open jdsika opened 1 year ago
Ok, I'm on it, going to open PR this the week.
Any progress here?
Sorry, didn't have enough time. I'll get everything sorted at the end of this week.
I will release v11.5 this weekend
The other PR is also dragging along. I just want to know if I should wait for you here as well?
to unstuck #613 I am documenting the things that may need consideration: src/calc/phased_payment_calculator.py Please remove the return statement and the rerun variable since it is redundant. The function calculate returns anyway with reward_logs and the total reward amount. Ofc it sorts and logs in between but it should be fine.
I can attempt to fix https://github.com/Vlad1mir-D/tezos-reward-distributor/tree/minpayment-phased and implement this part without recursion but honestly I don't think there is any reason to feel any hesitation about recursion.
I'm not using dry-run mode because currently it requires an access to the signer and this destroys the whole idea of "dry run" as I'm afraid to provide an access to signer. So I can't comment this issue.
I'm not sure what you mean by "help" so I think it definitely won't help with this thing :)
In current implementation - yes, they will be marked with
min_delegation_amt
.I would say this could be a confusing statement but there many other parts in TRD that's really confusing to me and this is among others is the reason I decided not to add an additional keyword.
What do you mean by "connected"? There could be situations where both
min_payment_amt
andmin_delegation_amt
will be defined in config but only one of them in current implementation could "win" (i.e. exclude most of the payments as the exclusion starts from the bottom) so I don't see any issues except confusion such report could represent but it could be addressed in the documentation.Well, it's possible to keep both reasons in the report, i.e. when payment is excluded due to one of the
minpayment
ormindelegation
- there will be only one notice and when payment excluded by both thresholds there will be two notices.To summarize:
minpayment
to therules_map
with the same options which currently available formindelegation
mindelegation
andminpayment
exclusion reasons in the report whenever payment get excluded