Closed denver-s closed 1 year ago
Please give the source for this
Please give the source for this
I added a test and and a real-case example.
I cannot see the test. Maybe you forgot to push? Also please state the effort in hours, thanks :)
Sorry, the test is described in the PR description. It's not a CI test. p.s. It's just a small contribution 🙂
hm... ok. Can you try your next payouts with this setting and report if it worked? (just paranoid)
FYI: tz1-to-tz1 transactions consume 1000040
milligas, but it is simplified to 1000
gas on the explorers. That's the reason for the choice of 1001
and not 1000
.
We did two payouts on this branch - worked!
name: Change gas limit for tz1 to tz1 transactions about: Minimum gas for a simple tz1 to tz1 transaction is 1001. labels:
IMPORTANT NOTICE: I read and understood the guidelines for contributions to the TRD. The contribution may qualify for being compensated by the TRD grant if approved by the maintainers.
In order to test the minimum gas required for such a transaction, one could run this command:
./octez-client transfer 1 from tz1_acc_1 to tz1_acc_2 --dry-run --gas-limit 1001
And verify that it works. Then, one could check that 1000 is too low:
A random example from a real transaction: https://tzkt.io/onoT7ARjiyx45nfCNiQkRPyH7CPSwdQtvrGpXJmyXwyEPzM3Fwe/88049298
Check list:
[x] I extended the Github Actions CI test units with the corresponding tests for this new feature (if needed).
[x] I extended the Sphinx documentation (if needed).
[x] I extended the help section (if needed).
[x] I changed the README file (if needed).
[x] I created a new issue if there is further work left to be done (if needed).
Work effort: 0.5 h