name: Pull Request
about: Create a pull request to make a contribution
labels:
IMPORTANT NOTICE:
I read and understood the guidelines for contributions to the TRD. The contribution may qualify for being compensated by the TRD grant if approved by the maintainers.
This PR resolves the issue . The following steps were performed:
Analysis: If an account needs to be reactivated there are cases where payment is attempted and gives false positives as the uninitialized account creates a rollback of payments.
Solution: Confirm that all uninitialized payment accounts are handled correctly by either skipping or paying for initialized free.
Implementation: Found in CalculatePhaseZero we are checking if the delegate.type == reward_log.TYPE_DELEGATOR and this issue can result in more than just a delegator.
Performed tests: Ran a bunch of dry runs and ghostnet runs. Confirmed that reactivate_zerod works as expected and we don't see the rollback we are seeing before. Also wrote a few unittests for CalculatePhaseZero
Work effort: 4h (took me a long time to recreate issue and then figure out why it was happening)
name: Pull Request about: Create a pull request to make a contribution labels:
IMPORTANT NOTICE: I read and understood the guidelines for contributions to the TRD. The contribution may qualify for being compensated by the TRD grant if approved by the maintainers.
This PR resolves the issue. The following steps were performed:
Analysis: If an account needs to be reactivated there are cases where payment is attempted and gives false positives as the uninitialized account creates a rollback of payments.
Solution: Confirm that all uninitialized payment accounts are handled correctly by either skipping or paying for initialized free.
Implementation: Found in CalculatePhaseZero we are checking if the delegate.type == reward_log.TYPE_DELEGATOR and this issue can result in more than just a delegator.
Performed tests: Ran a bunch of dry runs and ghostnet runs. Confirmed that reactivate_zerod works as expected and we don't see the rollback we are seeing before. Also wrote a few unittests for CalculatePhaseZero
Work effort: 4h (took me a long time to recreate issue and then figure out why it was happening)
GIF TAX: