name: Pull Request
about: Create a pull request to make a contribution
labels:
IMPORTANT NOTICE:
I read and understood the guidelines for contributions to the TRD. The contribution may qualify for being compensated by the TRD grant if approved by the maintainers.
This PR resolves the issue #655. The following steps were performed:
Analysis: This issue was introduced as during the configure script upgrade there was a desire to ensure all of the addresses were correct. An incorrect assumption was made that the baker address was required to be known by the signer. This did not cause any issues while developing as I happened to have the baker known by my signer, but for other users this was spotted as they do not.
Solution: Make sure that the baker address does not get checked by the signer.
Implementation: Removed the check_pkh_known_by_signer method being called in validate baking address.
Performed tests: Removed the address from my known lists. Was able to replicate the issue while running dry run. Removed the check and ran dry run again. Was able to complete. Ran without dry run and was also able to complete.
Documentation: Make sure to document the added changes in a proper way (Readme, help section, documentation, comments in code if needed)
name: Pull Request about: Create a pull request to make a contribution labels:
IMPORTANT NOTICE: I read and understood the guidelines for contributions to the TRD. The contribution may qualify for being compensated by the TRD grant if approved by the maintainers.
This PR resolves the issue #655. The following steps were performed:
Analysis: This issue was introduced as during the configure script upgrade there was a desire to ensure all of the addresses were correct. An incorrect assumption was made that the baker address was required to be known by the signer. This did not cause any issues while developing as I happened to have the baker known by my signer, but for other users this was spotted as they do not.
Solution: Make sure that the baker address does not get checked by the signer.
Implementation: Removed the check_pkh_known_by_signer method being called in validate baking address.
Performed tests: Removed the address from my known lists. Was able to replicate the issue while running dry run. Removed the check and ran dry run again. Was able to complete. Ran without dry run and was also able to complete.
Documentation: Make sure to document the added changes in a proper way (Readme, help section, documentation, comments in code if needed)
Work effort: 0.5h