name: Fix for level_in_cycle calculation since Mumbai
about: Create a pull request to make a contribution
labels:
IMPORTANT NOTICE:
I read and understood the guidelines for contributions to the TRD. The contribution may qualify for being compensated by the TRD grant if approved by the maintainers.
The following steps were performed:
Analysis: New protocol constants introduced a bug for level_in_cycle calculation
Solution: Mumbai doubled number of blocks per cycle which needed a new level_in_cycle calculation for levels after the first Mumbai level.
Implementation: Added new constants for FIRST_MUMBAI_LEVEL and added new condition in level_in_cycle
Performed tests: Added new block api tests for level_in_cycle for various levels
Documentation: Make sure to document the added changes in a proper way (Readme, help section, documentation, comments in code if needed)
Check list:
[ ] I extended the Github Actions CI test units with the corresponding tests for this new feature (if needed).
[ ] I extended the Sphinx documentation (if needed).
[ ] I extended the help section (if needed).
[ ] I changed the README file (if needed).
[ ] I created a new issue if there is further work left to be done (if needed).
name: Fix for level_in_cycle calculation since Mumbai about: Create a pull request to make a contribution labels:
IMPORTANT NOTICE: I read and understood the guidelines for contributions to the TRD. The contribution may qualify for being compensated by the TRD grant if approved by the maintainers.
The following steps were performed:
Analysis: New protocol constants introduced a bug for
level_in_cyclecalculationSolution: Mumbai doubled number of blocks per cycle which needed a new
level_in_cyclecalculation for levels after the first Mumbai level.Implementation: Added new constants for
FIRST_MUMBAI_LEVELand added new condition inlevel_in_cyclePerformed tests: Added new block api tests for
level_in_cyclefor various levelsDocumentation: Make sure to document the added changes in a proper way (Readme, help section, documentation, comments in code if needed)
Check list:
[ ] I extended the Github Actions CI test units with the corresponding tests for this new feature (if needed).
[ ] I extended the Sphinx documentation (if needed).
[ ] I extended the help section (if needed).
[ ] I changed the README file (if needed).
[ ] I created a new issue if there is further work left to be done (if needed).
Work effort: 1 hour