tezos-reward-distributor-organization / tezos-reward-distributor

Tezos Reward Distributor (TRD): A reward distribution software for tezos bakers.
https://tezos-reward-distributor-organization.github.io/tezos-reward-distributor/
GNU General Public License v3.0
87 stars 51 forks source link

TzStats "offline_losses" is not working #682

Open denver-s opened 11 months ago

denver-s commented 11 months ago

Describe the bug Test for API consistency is failing because TzStats does not provide the values to calculate "offline losses" (baking and endorsing).

To Reproduce Look at the CI.

Solution Temporary suspend that test or change the calculation (consider only expected/actual income?).

echa commented 11 months ago

It exists and is called seed_loss (details are lost_seed_fees and lost_seed_rewards) and endorsing_loss.

See https://docs.tzpro.io/api/index/tables/income-table https://docs.tzpro.io/api/index/explorer/bakers#get-baker-cycle-income

Example https://api.tzpro.io/explorer/bakers/tz3ipHZQpBBFuxv7eKoFgGnTaU3RBhnS93yY/income/619?api_key=YOUR_API_KEY

denver-s commented 11 months ago

Might be wrong, but I think "baking loss" is necessary to be able to make the comparison.

echa commented 11 months ago

Can you define "baking loss" please?

denver-s commented 11 months ago

Rewards lost for blocks missed/not baked.