tezos-reward-distributor-organization / tezos-reward-distributor

Tezos Reward Distributor (TRD): A reward distribution software for tezos bakers.
https://tezos-reward-distributor-organization.github.io/tezos-reward-distributor/
GNU General Public License v3.0
87 stars 51 forks source link

signals workaround for windows #695

Closed nicolasochem closed 5 months ago

nicolasochem commented 5 months ago

SIGUSR1 and SIGUSR2 introduced in #679 don't work on windows. For windows, I revert to the previous behavior (always exit succesfully) by selectively importing signals based on OS. It works for me on linux, I don't have a windows machine to try.

Work: 1hr

jdsika commented 5 months ago

Was there a reason you used _signal instead of signal ? This seems to work.

nicolasochem commented 5 months ago

Was there a reason you used _signal instead of signal ? This seems to work.

just to make clear to the reader that it's our own internal variable and not some standard python var. but your commit is ok. good to merge as is.