tezos-reward-distributor-organization / tezos-reward-distributor

Tezos Reward Distributor (TRD): A reward distribution software for tezos bakers.
https://tezos-reward-distributor-organization.github.io/tezos-reward-distributor/
GNU General Public License v3.0
87 stars 51 forks source link

Warn instead of exit when new protocol live date is exceeded #701

Closed RdeWilde closed 1 month ago

RdeWilde commented 5 months ago

Is your feature request related to a problem? Please describe. Currently the application implements a hard cut-off date when the new protocol should be live. When running in non-interactive mode, this will cause our containers to crash-loop (obviously when there's no updated release before the deadline).

Describe the solution you'd like Make it (an option) to warn about the deadline, but not crash. Although the purpose of the check is clear, we don't want our containers to crash.

Describe alternatives you've considered Forking the repository and changing the deadline date manually or remove the code to exit the program

Additional context https://github.com/tezos-reward-distributor-organization/tezos-reward-distributor/blob/9e20ab33643929c3a90438f1aab5daa36b82a3c4/src/launch_common.py#L79

nicolasochem commented 4 months ago

hard agree :+1: