tezos-reward-distributor-organization / tezos-reward-distributor

Tezos Reward Distributor (TRD): A reward distribution software for tezos bakers.
https://tezos-reward-distributor-organization.github.io/tezos-reward-distributor/
GNU General Public License v3.0
87 stars 51 forks source link

Reactivate tests and remove dead code #706

Closed vkresch closed 3 weeks ago

vkresch commented 1 month ago

Use of pkg_resources is deprecated in favor of importlib.resources, importlib.metadata and their backports (importlib_resources, importlib_metadata). Some useful APIs are also provided by packaging (e.g. requirements and version parsing). Users should refrain from new usage of pkg_resources and should work to port to importlib-based solutions. Source: https://setuptools.pypa.io/en/latest/pkg_resources.html

Work effort: 8h Review time: 1h (nochem)

nicolasochem commented 1 month ago

thank you for this @vkresch

I see small changes in src/. I can test for cycle 751 payouts. Then we can merge this.

We can do a 13.1 release in a less rushed fashion. Anything else you'd like to do?

I am considering removing all code for owner and founder since it no longer makes sense in Paris protocol. See discussion on baking slack. Any thoughts on this? @vkresch @jdsika

vkresch commented 1 month ago

Thanks. During the test reactivation there were some Attribute not found errors of the PaymentProducer (for example self.exiting and self.payments_queue) so I moved the attribute definitions on top to avoid this. This should not break anything but please check and test this on your side.

I am considering removing all code for owner and founder since it no longer makes sense in Paris protocol. See discussion on baking slack. Any thoughts on this? @vkresch @jdsika

I think it is good step to clean up and simplify the code base. I already liked the move to only Tzkt API.

vkresch commented 3 weeks ago

Thanks! It worked for me, I had to fix a few things for docker to work.

Thanks!