Closed jvmncs closed 2 years ago
One concern I had: what happens when I feed a computation to the LocalMooseRuntime with placements that don't have corresponding identities in the runtime? Previously, we would error out, but now I think this kind of error might reach all the way into the AsyncTestRuntime and just result in hanging processes. Not totally sure about that yet though, will check it out tomorrow.
but now I think this kind of error might reach all the way into the AsyncTestRuntime and just result in hanging processes
Yes I think you might be right. At least if it makes it to AsyncExecutor::run_computation
, which will silently filter out operations and causing a hang.
Closes #1093 Closes #1094
Removes
role_assignments
fromLocalMooseRuntime.evaluate_computation
.The standard way to construct
LocalMooseRuntime
is now:For adding storage to the simulated hosts:
Also removes
role_assignment
from AsyncTestRuntime, since it's purpose is nearly identical as the python version. Note that AsyncSession still requires arole_assignment: HashMap<Role, Identity>
, since this reaches deeper into the Moose code than I wanted this change to go.Rewrote a bit of the correlation notebook example to match this (and also fixed a tiny bug)