search

tf-redfree / PHP-btce-api

BTC-e API Class
MIT License
44 stars 41 forks source link

Fixed noonce runtime autocorrection #7

Closed xaionaro closed 9 years ago

xaionaro commented 9 years ago

See: https://github.com/marinu666/PHP-btce-api/issues/6

xaionaro commented 9 years ago

Cleaned up.

However I disagree about $new_noonce :). Repeating $matches[1] is a bad coding style, IMHO.

tf-redfree commented 9 years ago

Two lines below we use it and it's used in context. Assigning an extra variable takes time, as speed is important for applications of the API, and PHP is pretty slow. The choice for this is just because we want it to be as fast as possible. I'll get this merged in :)