search

tf / redmine_merge_request_links

Display links to associated Gitlab merge requests and GitHub pull requests on Redmine's issue page.
https://www.redmine.org/plugins/redmine_merge_request_links
MIT License
35 stars 26 forks source link

Patch fails for Redmine 3.4.11 #14

Closed tofi86 closed 5 years ago

tofi86 commented 5 years ago

Hi, I'm using Redmine 3.4.11 and ypur plugin v2.1.1 but after updating from 3.4.10 to 3.4.11 the patch fails:

/var/www/redmine# git apply plugins/redmine_merge_request_links/patches/view_hook_issues_show_after_details.patch
error: patch failed: app/views/issues/show.html.erb:118
error: app/views/issues/show.html.erb: patch does not apply

Can you provide an updated patch please?

Thanks for this great plugin!

Best, Tobias

tf commented 5 years ago

The patch still works for me in Redmine 3.4.11. It fails, though, in Redmine 4.0.4 (see Travis build). I've added a new patch that works with Redmine 4.0.4 in #15.

tofi86 commented 5 years ago

Sorry, totally my fault 🙈 I was blind and already had it applied... 🙄