search

tf / redmine_merge_request_links

Display links to associated Gitlab merge requests and GitHub pull requests on Redmine's issue page.
https://www.redmine.org/plugins/redmine_merge_request_links
MIT License
35 stars 26 forks source link

WIP: Project based tokens #19

Open saitho opened 5 years ago

saitho commented 5 years ago

Hi,

I started working on project-based tokens (#17).

Still have to do some testing and adjust the tests. Also the project settings I added currently don't show up anymore. :D

This also makes it mandatory to check if the token used in the request exists in environment or database. So far I did that check for Gitea. Still have to look into the data provided by Gitlab and GitHub (although GitHub might be the same as Gitea).

Oh btw I also added the Gitea icon which is I forgot before. Might put that into a separate pull request if you mind that it's included here.

tf commented 5 years ago

Thanks for your contribution. So far I did not get around to taking a closer look. I'll be on vacation next week. So in case the PR should be ready for review earlier, I won't be able to respond until after I return.

saitho commented 4 years ago

Finally continued working on this. I had some problems with the existing tests. Turned out my addition to remove relations between a PR and a ticket if the PR does not have any ticket numbers in it anymore broke it. (see https://github.com/tf/redmine_merge_request_links/pull/19/files#diff-f7fcc50bb328801f4c62fe015fac1973R17). I'm not sure if GitHub, GitLab and Gitea always provide the full information when a PR was edited. If they do we can just adjust the tests to include a ticket id.

Also I had to change the way how I access the secret in the Gitea handler in order for the tests to work as I was expecting JSON data... My local tests were successful before - will have to check if it still works with an actual Gitea system sending data. ;)