tf / redmine_merge_request_links

Display links to associated Gitlab merge requests and GitHub pull requests on Redmine's issue page.
https://www.redmine.org/plugins/redmine_merge_request_links
MIT License
35 stars 26 forks source link

Broken layout on issue detail page on Redmine 4.1 #26

Open sandratatarevicova opened 4 years ago

sandratatarevicova commented 4 years ago

The patch introduced in #25 (fix for #24) is not optimal, because it only modifies the old patch to be applicable on Redmine 4.1. The current version of the plugin with patch from #24 is not compatible with issue history tabs and it breaks the page layout on the issue detail page, see the screenshot below.

Screenshot 2020-03-25 at 10 57 26

I think that there should be a new tab Associated merge requests (similarly as Associated revisions).

tf commented 4 years ago

I argee that making the tab content flow around the MR box like that is far from ideal. Turning the MRs into a tab - while being more consistent - would feel like a change for the worse to me, though, since it places MRs one click further away. I use the list all of the time to quickly jump from issues to MRs.

alexandermalfait commented 4 years ago

See merge request #28 for a version without an extra click, working on Redmine 4.1