Redmine Pull request disappears

[calvu]

Hello,

My setup:

• Redmine 3.4.13 (also tested with 3.4.6)
• Gitea 1.11.6
• Plugin v2.22

Problem: Creating a pullrequest with the ticket number "#1234" within Gitea creates an entry in the Redmine Ticket. As soon as the pullrequest is closed, by Merge or Close, the entry disappears in the ticket. I have already looked at the Redmine DB and noticed the following behavior.

• When a pull request is created, "merge_requests" and "issues_merge_requests" creates the corresponding entries in the table.
• When merging a pull request, the entry is deleted from the "issues_merge_requests" table and no new one is created.

Greetings, Peter

[tf]

Maybe the webhook sent on close does not contain the description/body? Every time that is changed, the linked merge requests are updated.

I'm not using the Gitea integration myself. So I can only guess. Maybe @saitho who developed the adapter has more ideas?

[jpraet]

I am experiencing the same issue. Indeed the body is empty in gitea's PR merged/closed webhook payload.

[tf]

Maybe we can make the Gitea adater only update the description if the corresponding field is present? Happy to accept a PR that adds a test case similar to the existing ones with a webhook payload that represents this case and makes sure.

[jpraet]

It will be fixed on the Gitea side in the upcoming 1.14.3 patch release.