added patch for 5.0 and modified init.rb and lib/redmine_merge_reques… - Githubissues

tf / redmine_merge_request_links

Display links to associated Gitlab merge requests and GitHub pull requests on Redmine's issue page.

https://www.redmine.org/plugins/redmine_merge_request_links

MIT License

35 stars 26 forks source link

added patch for 5.0 and modified init.rb and lib/redmine_merge_reques… #37

Closed nnnajwa closed 2 years ago

nnnajwa commented 2 years ago

Created patch for redmine 5.0 and modified init.rb and lib/redmine_merge_request_links.rb to support Redmine 5 (Rails 6)
Stylesheet redmine_merge_request_links.css will need some adjusting so that the div corresponding to the merge requests can blend into the redmine 5.0 page structure more seamlessly

tf commented 2 years ago

Thanks for the PR! From an purely aesthetic point of view, I think I slightly prefer the require_relative approach proposed in #38. Do you see any downsides?

Stylesheet redmine_merge_request_links.css will need some adjusting so that the div corresponding to the merge requests can blend into the redmine 5.0 page structure more seamlessly

Are there additional display issues in Redmine 5 beyond what has been mentioned in #26?

nnnajwa commented 2 years ago

Thanks for the PR! From an purely aesthetic point of view, I think I slightly prefer the require_relative approach proposed in #38. Do you see any downsides?

Agreed, the require_relative seems simpler to understand and does the job as well .

Are there additional display issues in Redmine 5 beyond what has been mentioned in #26?

No, nothing beyond that small glitch. I hadn't seen that the issue had already been mentionned. Thanks for the comment !

tf commented 2 years ago

Alright. I've merged #38 now.