search

tf / redmine_merge_request_links

Display links to associated Gitlab merge requests and GitHub pull requests on Redmine's issue page.
https://www.redmine.org/plugins/redmine_merge_request_links
MIT License
35 stars 26 forks source link

basic permissions #4

Closed tofi86 closed 5 years ago

tofi86 commented 5 years ago

Use redmine built-in :browse_repository permissions to view the MergeRequest box. This hides the box from external users who are not allowed to view the "repositories" tab in the project.

However, this is kind of a hacky solution for permission handling. There's better ways, see for example https://github.com/paginagmbh/redmine_silencer/blob/master/init.rb#L12 to add a new permission for Roles.

tf commented 5 years ago

Good point! Coupling this to :browse_repository is probably good enough for now. Can you add a functional test that covers the case when the merge request box is not visible? Also the branch needs a rebase now that I merged the localization changes.

tofi86 commented 5 years ago

I rebased the branch on your current master.

However, I won't have time these days to add the test for it. Any chance you can take a look?

tofi86 commented 5 years ago

Awesome, thanks!