tf2classic / TF2CDownloader

Cross-platform utility for automatically downloading and installing TF2 Classic
GNU General Public License v3.0
48 stars 13 forks source link

Inconsistent error with finding zstd.exe in version 2022-06-09 #13

Closed chloecormier closed 2 years ago

chloecormier commented 2 years ago

It's hard for me to even test this myself, but two separate testers have reported getting this on the Windows version of 2022-06-09:

tar (child): zstd.exe: Cannot exec: No such file or directory

In my Windows 10 VM, I can't reproduce this at all and the application runs fine.

Testing this at all requires using PyInstaller, as Zstd.exe is detected differently whether you're running this as a script or running it compiled.

For the time being, 2022-06-09 is not being used anywhere except for the Dedicated Linux Server guide, as this issue is Windows-only.

I suspect the issue is that, on certain setups, the addition of PyInstaller's temporary runtime folder to the %PATH% isn't getting recognized properly. Any help in understanding or fixing the issue would be greatly appreciated.

chloecormier commented 2 years ago

Solved in https://github.com/tf2classic/TF2CDownloader/commit/948ca53eba0ec162c2d7bde1af5664ea84ffb76f (by removing zstd.exe outright)