search

tf2td / towerdefense

Tower defense mod for Team Fortress 2
GNU General Public License v3.0
25 stars 10 forks source link

Translation support? #9

Closed Blueberryy closed 10 months ago

Blueberryy commented 3 years ago

As any other plugin maybe you will add some translation support to make gamemode more accessible?

Dragonisser commented 1 year ago

Possible, need to check how its done but shouldn't be too hard.

Dragonisser commented 1 year ago

https://github.com/tf2td/towerdefense/pull/23

Blueberryy commented 1 year ago

https://github.com/tf2td/towerdefense/pull/23

Thanks for implementing that!

Dragonisser commented 1 year ago

Its not fully done yet, just linking the draft ;)

Blueberryy commented 10 months ago

Congrats with finishing this! I will make a pull request when i finish Russian translation soon 🎊

Blueberryy commented 10 months ago

And i hope that tower names, shop and other maps related things will be added to file

Dragonisser commented 10 months ago

Most of it wont be possible since its stored in the database. Would require a lot of changes.

Issue with that is simple. The database was created to easily expand the waves, bots, etc, without having to touch the plugin. Since ive changed how translation works it might be possible to do this, but it would end up with people having to edit the translation files as soon as anyone wants to add something new.

Ill have to think about it.

My focus right now is to get rid of some bugs that are quite annoying.

Dragonisser commented 10 months ago

@Blueberryy you need to update the russian translation again.

Blueberryy commented 10 months ago

Most of it wont be possible since its stored in the database. Would require a lot of changes.

Issue with that is simple. The database was created to easily expand the waves, bots, etc, without having to touch the plugin. Since ive changed how translation works it might be possible to do this, but it would end up with people having to edit the translation files as soon as anyone wants to add something new.

Ill have to think about it.

My focus right now is to get rid of some bugs that are quite annoying.

i think you should add some documentation about adding custom things, like maybe you can add whole new translation file for that like towerdefense_custom_items.txt

Dragonisser commented 10 months ago

Most of it wont be possible since its stored in the database. Would require a lot of changes. Issue with that is simple. The database was created to easily expand the waves, bots, etc, without having to touch the plugin. Since ive changed how translation works it might be possible to do this, but it would end up with people having to edit the translation files as soon as anyone wants to add something new. Ill have to think about it. My focus right now is to get rid of some bugs that are quite annoying.

i think you should add some documentation about adding custom things, like maybe you can add whole new translation file for that like towerdefense_custom_items.txt

Its not the issue where the translation is added, but rather that it needs to be done in the translation files which it currently doesnt. Priorities are on different things right now.