tfabris / CrowCam

A set of Bash scripts to control and maintain a YouTube live cam from a Synology NAS.
GNU General Public License v3.0
4 stars 3 forks source link

Network retry code: Verify behavior and clarify code comments and log messages. #8

Closed tfabris closed 5 years ago

tfabris commented 5 years ago

The code which detects that the network has gone down and come back up again, and which restarts the YouTube stream if needed, has been tweaked a few times since it was written. Now, instead of the single loop of testing the network itself a few times a minute, it also has a new "inner" loop of testing the stream to see if it's up or not.

To do:

tfabris commented 5 years ago

This issue may be the root cause of issue #9 :

  • Revisit the code to make sure it's doing what you intend. If the network goes down (as opposed to the stream itself failing) it should make sure to bounce the stream right away when the network comes back up, instead of sitting in the inner loop rechecking the stream.
tfabris commented 5 years ago

I have checked in a commit which attempts to address issues #8 and #9 . Will test to make sure these are working correctly in production before I close these bugs.

tfabris commented 5 years ago

I'm running these changes on production now so I'm closing this bug.